FreeBSD › freebsd-java

Re: ports/162991: java/openjdk6 fails to build [patch] [redports]

Classic

List

Threaded

7 messages Options

Volodymyr Kostyrko

Re: ports/162991: java/openjdk6 fails to build [patch] [redports]

The following reply was made to PR ports/162991; it has been noted by GNATS.

From: Volodymyr Kostyrko <[hidden email]>
To: [hidden email], [hidden email]
Cc:
Subject: Re: ports/162991: java/openjdk6 fails to build [patch] [redports]
Date: Thu, 08 Mar 2012 09:48:32 +0200

This is a multi-part message in MIME format.
--------------070508070807020602080200
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Ok, I found time to investigate it.

Everything is about arch guessing. java/openjdk7 substitutes amd64 for
x86_64 while java/openjdk6 doesn't. I just added missing bits from
correspondent java/openjdk7 patch.

Redports build: https://redports.org/buildarchive/20120307160255-45601

Patch attached.

--
Sphinx of black quartz judge my vow.

--------------070508070807020602080200
Content-Type: text/plain;
name="openjdk6.patch.txt"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="openjdk6.patch.txt"

ZGlmZiAtdXJOIC91c3IvcG9ydHMvamF2YS9vcGVuamRrNi9maWxlcy9wYXRjaC1zZXQgb3Bl
bmpkazYvZmlsZXMvcGF0Y2gtc2V0Ci0tLSAvdXNyL3BvcnRzL2phdmEvb3BlbmpkazYvZmls
ZXMvcGF0Y2gtc2V0CTIwMTItMDEtMTQgMDQ6MTU6MzIuMjQ0OTc1NjQ2ICswMjAwCisrKyBv
cGVuamRrNi9maWxlcy9wYXRjaC1zZXQJMjAxMi0wMy0wOCAwOTo0Mjo0OS45NTc1NTQzNTMg
KzAyMDAKQEAgLTMyNCw3ICszMjQsNyBAQAogK2VuZGlmCiAtLS0gY29yYmEvbWFrZS9jb21t
b24vc2hhcmVkL1BsYXRmb3JtLmdtawkyMDExLTA3LTA1IDE0OjI5OjIyLjAwMDAwMDAwMCAt
MDQwMAogKysrIGNvcmJhL21ha2UvY29tbW9uL3NoYXJlZC9QbGF0Zm9ybS5nbWsJMjAxMS0w
Ny0wNyAxOToxNzowMi4wMDAwMDAwMDAgLTA0MDAKLUBAIC0yNjEsNiArMjYxLDc2IEBACitA
QCAtMjYxLDYgKzI2MSw3OSBAQAogICAgTUJfT0ZfTUVNT1JZIDo9ICQoc2hlbGwgZnJlZSAt
bSB8IGZncmVwIE1lbTogfCBzZWQgLWUgJ3NAXCBcICpAIEBnJyB8IGN1dCAtZCcgJyAtZjIp
CiAgZW5kaWYKICAKQEAgLTM2NSw2ICszNjUsOSBAQAogKyAgICAgICAgICAgICAgICBpWzMt
OV04NikgXAogKyAgICAgICAgICAgICAgICAgICAgZWNobyBpNTg2IFwKICsgICAgICAgICAg
ICAgICAgICAgIDs7IFwKKysgICAgICAgICAgICAgICAgeDg2XzY0KSBcCisrICAgICAgICAg
ICAgICAgICAgICBlY2hvIGFtZDY0IFwKKysgICAgICAgICAgICAgICAgICAgIDs7IFwKICsg
ICAgICAgICAgICAgICAgKikgXAogKyAgICAgICAgICAgICAgICAgICAgZWNobyAkKG1hY2gp
IFwKICsgICAgICAgICAgICAgICAgICAgIDs7IFwK
--------------070508070807020602080200--
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"

Jung-uk Kim

Re: ports/162991: java/openjdk6 fails to build

On Thursday 08 March 2012 02:50 am, Volodymyr Kostyrko wrote:

> Ok, I found time to investigate it.
>
> Everything is about arch guessing. java/openjdk7 substitutes amd64
> for x86_64 while java/openjdk6 doesn't. I just added missing bits
> from correspondent java/openjdk7 patch.
>
> Redports build:
> https://redports.org/buildarchive/20120307160255-45601
>
> Patch attached.

Sorry but it doesn't make any sense. I guess you are patching this:

...
# Platform settings specific to BSD
ifeq ($(PLATFORM), bsd)
OS_VERSION := $(shell uname -r)
# Arch and OS name/version
mach := $(shell uname -m)
archExpr = case "$(mach)" in \
i[3-9]86) \
echo i586 \
;; \
*) \
echo $(mach) \
;; \
esac
ARCH := $(shell $(archExpr) )
ARCH_FAMILY := $(ARCH)
...

Unless "UNAME_m" environment variable is set, there is no way that
this patch does anything at all.

% uname -r
10.0-CURRENT
% uname -m
amd64
% env UNAME_m=x86_64 uname -m
x86_64

I believe OpenJDK7 added it because some BSDs (e.g., DragonFlyBSD)
return x86_64 for "uname -m".

BTW, does "make DISABLE_MAKE_JOBS=yes" make any difference?

Thanks,

Jung-uk Kim
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"

Jung-uk Kim

Re: ports/162991: java/openjdk6 fails to build

The following reply was made to PR ports/162991; it has been noted by GNATS.

From: Jung-uk Kim <[hidden email]>
To: [hidden email],
Volodymyr Kostyrko <[hidden email]>
Cc: [hidden email]
Subject: Re: ports/162991: java/openjdk6 fails to build
Date: Thu, 8 Mar 2012 13:09:51 -0500

On Thursday 08 March 2012 02:50 am, Volodymyr Kostyrko wrote:
> Ok, I found time to investigate it.
>
> Everything is about arch guessing. java/openjdk7 substitutes amd64
> for x86_64 while java/openjdk6 doesn't. I just added missing bits
> from correspondent java/openjdk7 patch.
>
> Redports build:
> https://redports.org/buildarchive/20120307160255-45601
>
> Patch attached.

Sorry but it doesn't make any sense. I guess you are patching this:

...
# Platform settings specific to BSD
ifeq ($(PLATFORM), bsd)
OS_VERSION := $(shell uname -r)
# Arch and OS name/version
mach := $(shell uname -m)
archExpr = case "$(mach)" in \
i[3-9]86) \
echo i586 \
;; \
*) \
echo $(mach) \
;; \
esac
ARCH := $(shell $(archExpr) )
ARCH_FAMILY := $(ARCH)
...

Unless "UNAME_m" environment variable is set, there is no way that
this patch does anything at all.

% uname -r
10.0-CURRENT
% uname -m
amd64
% env UNAME_m=x86_64 uname -m
x86_64

I believe OpenJDK7 added it because some BSDs (e.g., DragonFlyBSD)
return x86_64 for "uname -m".

BTW, does "make DISABLE_MAKE_JOBS=yes" make any difference?

Thanks,

Jung-uk Kim
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"

Volodymyr Kostyrko

Re: ports/162991: java/openjdk6 fails to build

In reply to this post by Jung-uk Kim

Jung-uk Kim wrote:

> On Thursday 08 March 2012 02:50 am, Volodymyr Kostyrko wrote:
>> Ok, I found time to investigate it.
>>
>> Everything is about arch guessing. java/openjdk7 substitutes amd64
>> for x86_64 while java/openjdk6 doesn't. I just added missing bits
>> from correspondent java/openjdk7 patch.
>>
>> Redports build:
>> https://redports.org/buildarchive/20120307160255-45601
>>
>> Patch attached.
>
> Sorry but it doesn't make any sense. I guess you are patching this:
>
> ...
> # Platform settings specific to BSD
> ifeq ($(PLATFORM), bsd)
> OS_VERSION := $(shell uname -r)
> # Arch and OS name/version
> mach := $(shell uname -m)
> archExpr = case "$(mach)" in \
> i[3-9]86) \
> echo i586 \
> ;; \
> *) \
> echo $(mach) \
> ;; \
> esac
> ARCH := $(shell $(archExpr) )
> ARCH_FAMILY := $(ARCH)
> ...
>
> Unless "UNAME_m" environment variable is set, there is no way that
> this patch does anything at all.
>
> % uname -r
> 10.0-CURRENT
> % uname -m
> amd64
> % env UNAME_m=x86_64 uname -m
> x86_64
>
> I believe OpenJDK7 added it because some BSDs (e.g., DragonFlyBSD)
> return x86_64 for "uname -m".

So why it ends up in our port and not in DragonFlyBSD's pkgsrc?

> BTW, does "make DISABLE_MAKE_JOBS=yes" make any difference?

Actually after successful build I can't reproduce this issue anymore. I
seem to miss some bits of data so I'll try to retest in clean environment.

--
Sphinx of black quartz judge my vow.
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"

Volodymyr Kostyrko

Re: ports/162991: java/openjdk6 fails to build

In reply to this post by Jung-uk Kim

The following reply was made to PR ports/162991; it has been noted by GNATS.

From: Volodymyr Kostyrko <[hidden email]>
To: Jung-uk Kim <[hidden email]>
Cc: [hidden email], [hidden email]
Subject: Re: ports/162991: java/openjdk6 fails to build
Date: Mon, 12 Mar 2012 17:26:26 +0200

Jung-uk Kim wrote:
> On Thursday 08 March 2012 02:50 am, Volodymyr Kostyrko wrote:
>> Ok, I found time to investigate it.
>>
>> Everything is about arch guessing. java/openjdk7 substitutes amd64
>> for x86_64 while java/openjdk6 doesn't. I just added missing bits
>> from correspondent java/openjdk7 patch.
>>
>> Redports build:
>> https://redports.org/buildarchive/20120307160255-45601
>>
>> Patch attached.
>
> Sorry but it doesn't make any sense. I guess you are patching this:
>
> ...
> # Platform settings specific to BSD
> ifeq ($(PLATFORM), bsd)
> OS_VERSION := $(shell uname -r)
> # Arch and OS name/version
> mach := $(shell uname -m)
> archExpr = case "$(mach)" in \
> i[3-9]86) \
> echo i586 \
> ;; \
> *) \
> echo $(mach) \
> ;; \
> esac
> ARCH := $(shell $(archExpr) )
> ARCH_FAMILY := $(ARCH)
> ...
>
> Unless "UNAME_m" environment variable is set, there is no way that
> this patch does anything at all.
>
> % uname -r
> 10.0-CURRENT
> % uname -m
> amd64
> % env UNAME_m=x86_64 uname -m
> x86_64
>
> I believe OpenJDK7 added it because some BSDs (e.g., DragonFlyBSD)
> return x86_64 for "uname -m".

So why it ends up in our port and not in DragonFlyBSD's pkgsrc?

> BTW, does "make DISABLE_MAKE_JOBS=yes" make any difference?

Actually after successful build I can't reproduce this issue anymore. I
seem to miss some bits of data so I'll try to retest in clean environment.

--
Sphinx of black quartz judge my vow.
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"

Jung-uk Kim

Re: ports/162991: java/openjdk6 fails to build

In reply to this post by Volodymyr Kostyrko

On Monday 12 March 2012 11:26 am, Volodymyr Kostyrko wrote:

> Jung-uk Kim wrote:
> > On Thursday 08 March 2012 02:50 am, Volodymyr Kostyrko wrote:
> >> Ok, I found time to investigate it.
> >>
> >> Everything is about arch guessing. java/openjdk7 substitutes
> >> amd64 for x86_64 while java/openjdk6 doesn't. I just added
> >> missing bits from correspondent java/openjdk7 patch.
> >>
> >> Redports build:
> >> https://redports.org/buildarchive/20120307160255-45601
> >>
> >> Patch attached.
> >
> > Sorry but it doesn't make any sense. I guess you are patching
> > this:
> >
> > ...
> > # Platform settings specific to BSD
> > ifeq ($(PLATFORM), bsd)
> > OS_VERSION := $(shell uname -r)
> > # Arch and OS name/version
> > mach := $(shell uname -m)
> > archExpr = case "$(mach)" in \
> > i[3-9]86) \
> > echo i586 \
> > ;; \
> > *) \
> > echo $(mach) \
> > ;; \
> > esac
> > ARCH := $(shell $(archExpr) )
> > ARCH_FAMILY := $(ARCH)
> > ...
> >
> > Unless "UNAME_m" environment variable is set, there is no way
> > that this patch does anything at all.
> >
> > % uname -r
> > 10.0-CURRENT
> > % uname -m
> > amd64
> > % env UNAME_m=x86_64 uname -m
> > x86_64
> >
> > I believe OpenJDK7 added it because some BSDs (e.g.,
> > DragonFlyBSD) return x86_64 for "uname -m".
>
> So why it ends up in our port and not in DragonFlyBSD's pkgsrc?

OpenJDK7 patchset is shared with other BSDs:

https://wikis.oracle.com/display/OpenJDK/BSDPort

OpenJDK6 patchset was based on early OpenJDK7 patchsets and it may or
may not build on other platforms. I am 99% sure it won't build on
DragonFlyBSD/x86-64, BTW.

> > BTW, does "make DISABLE_MAKE_JOBS=yes" make any difference?
>
> Actually after successful build I can't reproduce this issue
> anymore. I seem to miss some bits of data so I'll try to retest in
> clean environment.

These parallel build problems are very hard to reproduce. Actually, I
was never able to reproduce it myself.

Jung-uk Kim
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"

Jung-uk Kim

Re: ports/162991: java/openjdk6 fails to build

In reply to this post by Jung-uk Kim

The following reply was made to PR ports/162991; it has been noted by GNATS.

From: Jung-uk Kim <[hidden email]>
To: Volodymyr Kostyrko <[hidden email]>
Cc: [hidden email],
[hidden email]
Subject: Re: ports/162991: java/openjdk6 fails to build
Date: Mon, 12 Mar 2012 12:50:12 -0400

On Monday 12 March 2012 11:26 am, Volodymyr Kostyrko wrote:
> Jung-uk Kim wrote:
> > On Thursday 08 March 2012 02:50 am, Volodymyr Kostyrko wrote:
> >> Ok, I found time to investigate it.
> >>
> >> Everything is about arch guessing. java/openjdk7 substitutes
> >> amd64 for x86_64 while java/openjdk6 doesn't. I just added
> >> missing bits from correspondent java/openjdk7 patch.
> >>
> >> Redports build:
> >> https://redports.org/buildarchive/20120307160255-45601
> >>
> >> Patch attached.
> >
> > Sorry but it doesn't make any sense. I guess you are patching
> > this:
> >
> > ...
> > # Platform settings specific to BSD
> > ifeq ($(PLATFORM), bsd)
> > OS_VERSION := $(shell uname -r)
> > # Arch and OS name/version
> > mach := $(shell uname -m)
> > archExpr = case "$(mach)" in \
> > i[3-9]86) \
> > echo i586 \
> > ;; \
> > *) \
> > echo $(mach) \
> > ;; \
> > esac
> > ARCH := $(shell $(archExpr) )
> > ARCH_FAMILY := $(ARCH)
> > ...
> >
> > Unless "UNAME_m" environment variable is set, there is no way
> > that this patch does anything at all.
> >
> > % uname -r
> > 10.0-CURRENT
> > % uname -m
> > amd64
> > % env UNAME_m=x86_64 uname -m
> > x86_64
> >
> > I believe OpenJDK7 added it because some BSDs (e.g.,
> > DragonFlyBSD) return x86_64 for "uname -m".
>
> So why it ends up in our port and not in DragonFlyBSD's pkgsrc?

OpenJDK7 patchset is shared with other BSDs:

https://wikis.oracle.com/display/OpenJDK/BSDPort

OpenJDK6 patchset was based on early OpenJDK7 patchsets and it may or
may not build on other platforms. I am 99% sure it won't build on
DragonFlyBSD/x86-64, BTW.

> > BTW, does "make DISABLE_MAKE_JOBS=yes" make any difference?
>
> Actually after successful build I can't reproduce this issue
> anymore. I seem to miss some bits of data so I'll try to retest in
> clean environment.

These parallel build problems are very hard to reproduce. Actually, I
was never able to reproduce it myself.

Jung-uk Kim
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"