ports/170671: [MAINTAINER] games/twind: Makefile changed, OptionsNG

[nemysis]

>Number:         170671
>Category:       ports
>Synopsis:       [MAINTAINER] games/twind: Makefile changed, OptionsNG
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:      
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 16 15:40:09 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:

System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC
>Description:

Makefile changed, OptionsNG added

.if ${PORT_OPTIONS:MDATA}

.if ${PORT_OPTIONS:MDOCS}

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:

--- twind-1.1.0.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/games/twind/Makefile ./Makefile
--- /usr/ports/games/twind/Makefile 2012-05-03 22:56:57.000000000 +0200
+++ ./Makefile 2012-08-16 17:17:57.000000000 +0200
@@ -15,15 +15,20 @@
 
 LICENSE= GPLv2
 
+OPTIONS_DEFINE= DATA
+OPTIONS_DEFAULT= DATA
+
 USE_SDL= sdl image mixer
 MAKE_JOBS_SAFE= yes
 
-PLIST_FILES= bin/twind \
+PLIST_FILES= bin/${PORTNAME} \
  share/pixmaps/${PORTNAME}.png
 
 PORTDATA= *
 PORTDOCS= AUTHORS CREDITS ChangeLog NEWS README TODO
 
+.include <bsd.port.options.mk>
+
 do-build:
  cd ${WRKSRC} && ${CC} -o ${PORTNAME} ${CFLAGS} \
  -DDATA_PREFIX=\"${DATADIR}/\" -DAUDIO -DLINUX \
@@ -31,17 +36,22 @@
 do-install:
 # Executable
  ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin
-# Pixmaps
- ${INSTALL_DATA} ${WRKSRC}/graphics/twind.png ${PREFIX}/share/pixmaps/${PORTNAME}.png
+
 # Data
+.if ${PORT_OPTIONS:MDATA}
  ${MKDIR} ${DATADIR}
  @(cd ${WRKSRC} && ${COPYTREE_SHARE} "graphics music sound" ${DATADIR})
+.endif
+
+# Pixmaps
+ ${INSTALL_DATA} ${WRKSRC}/graphics/${PORTNAME}.png ${PREFIX}/share/pixmaps/
+
 # Documentation
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
  ${MKDIR} ${DOCSDIR}
-.for f in ${PORTDOCS}
+.  for f in ${PORTDOCS}
  ${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}
-.endfor
+.  endfor
 .endif
 
 .include <bsd.port.mk>
--- twind-1.1.0.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"

[nemysis]

The following reply was made to PR ports/170671; it has been noted by GNATS.

From: nemysis <[hidden email]>
To: [hidden email]
Cc:  
Subject: Re: ports/170671: [MAINTAINER] games/twind: Makefile changed,
 OptionsNG
Date: Thu, 16 Aug 2012 18:10:54 +0200

 Please change
 
 Severity: serious
 
 to
 
 Severity: non-critical
 
 This is a Mistake, sorry.
 
 
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"

[nemysis]

The following reply was made to PR ports/170671; it has been noted by GNATS.

From: nemysis <[hidden email]>
To: [hidden email]
Cc:  
Subject: Re: ports/170671: [MAINTAINER] games/twind: Makefile changed,
 OptionsNG
Date: Thu, 16 Aug 2012 23:28:15 +0200

 --MP_/TVO.TXJwbZq8/bCZ2y3Ox+Z
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 
 --MP_/TVO.TXJwbZq8/bCZ2y3Ox+Z
 Content-Type: text/x-patch
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=twind.diff
 
 diff -ruN twind.orig/Makefile twind/Makefile
 --- twind.orig/Makefile 2012-08-16 17:17:57.000000000 +0200
 +++ twind/Makefile 2012-08-16 23:25:50.000000000 +0200
 @@ -7,6 +7,7 @@
 
  PORTNAME= twind
  PORTVERSION= 1.1.0
 +PORTREVISION= 1
  CATEGORIES= games
  MASTER_SITES= SF/${PORTNAME}/${PORTNAME}/${PORTVERSION}
 
 
 --MP_/TVO.TXJwbZq8/bCZ2y3Ox+Z--
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"

[Dmitry Marakasov-3]

Synopsis: [MAINTAINER] games/twind: Makefile changed, OptionsNG

Responsible-Changed-From-To: freebsd-ports-bugs->amdmi3
Responsible-Changed-By: amdmi3
Responsible-Changed-When: Fri Aug 17 17:44:11 UTC 2012
Responsible-Changed-Why:
I'll take it.

http://www.freebsd.org/cgi/query-pr.cgi?pr=170671
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"